libp2p / libp2p/rust-libp2p

UPnP port mappings should be deleted on graceful shutdown

Open
#5,532 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
5.6k
Forks
1.3k
Avg merge
8h 47m
Merged PRs (30d)
19

Description

Description

UPnP port mappings should be deleted on graceful shutdown.

Motivation

The lease time for opened UPnP port mappings is quite long. It would be decent to remove any created port mappings on shutdown.

Current Implementation

On shutdown, port mappings just stay alive until the lease time is up.

Are you planning to do it yourself in a pull request ?

No

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the UPnP port-mapping creation and graceful-shutdown entry points, then verify that mappings created by the application are deleted during graceful shutdown instead of remaining until their lease expires.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.