libp2p / libp2p/rust-libp2p

gossipsub: add test for missed heartbeats

Open
#3,987 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

difficulty:moderate getting-started help wanted priority:nicetohave
Dominant language
Rust
Stars
5.6k
Forks
1.3k
Avg merge
8h 47m
Merged PRs (30d)
19

Description

We should have a test that ensure we "catch" up to missed heartbeats. For the underlying timer, this means implementing a "skip" behavior.

The test should be on a Swarm level ideally such that we don't rely on implementation details.

The cherry on the cake would be to run the test in wasm as well to make sure the timer implementation is always sane.

Originally discussed in https://github.com/libp2p/rust-libp2p/pull/3973#issuecomment-1562291148

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the gossipsub Swarm-level test described in the issue and inspect the underlying timer's skip behavior. Verify that missed heartbeats are caught up, then run the test in wasm as well if the existing test setup supports it.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.