gossipsub: Re-write tests to remove technical debt
Open
Nobody has claimed this yet.
difficulty:moderate
help wanted
priority:nicetohave
- Dominant language
- Rust
- Stars
- 5.6k
- Forks
- 1.3k
- Avg merge
- 8h 47m
- Merged PRs (30d)
- 19
Description
With https://github.com/libp2p/rust-libp2p/pull/3327, we took out some technical debt to move forward with #2824. The tests which currently depend on ConnectionId should be refactored to spin up a Swarm and establish an actual connection which will then allow us to remove ConnectionId::DUMMY.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the gossipsub tests that depend on ConnectionId and read the surrounding setup. Replace the test connections with a Swarm that establishes an actual connection, then verify the tests pass and that ConnectionId::DUMMY can be removed as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100