protocols/dcutr: Don't retry when incoming direct connection succeeded
Open
Nobody has claimed this yet.
bug
difficulty:moderate
getting-started
help wanted
- Dominant language
- Rust
- Stars
- 5.6k
- Forks
- 1.3k
- Avg merge
- 8h 47m
- Merged PRs (30d)
- 19
Description
As of today we retry the DCUtR process when the outgoing direct connection upgrade failed.
In the case where the incoming direction connection upgraded succeeded, there is no need for retrying the process.
We should check direct_connections to see whether an (incoming) direct connection succeeded in the meantime.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in protocols/dcutr/src/behaviour.rs around lines 152-180 and trace how the DCUtR retry decision uses direct_connections. Verify the incoming direct connection state before retrying after an outgoing upgrade failure. Done means the process does not retry when the incoming direction has already succeeded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100