Revisit high-level structure of pubsub tests after move to trio
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 624
- Forks
- 256
- Avg merge
- 1d 34m
- Merged PRs (30d)
- 47
Description
Cf. https://github.com/libp2p/py-libp2p/pull/372#discussion_r352925807
After we hit the first stable point after migrating to trio, it will make sense to revisit some of the gossipsub tests which may need some refactoring for maintainability's sake.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the discussion linked from pull request 372, then inspect the gossipsub tests affected by the move to trio. Identify the high-level structure that should be revisited after the migration reaches a stable point; done means the tests have a more maintainable structure without changing their intended coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100