Max size restriction applied to whole message not just data
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 5
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
For incoming messages the max size restriction is applied to the whole message, not just the data field:
https://github.com/libp2p/pull-mplex/blob/master/src/mplex.js#L84-L93
The spec says that the data field can be up to 1MB so this will be causing false positives for certain message sizes.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/mplex.js lines 84-93 and compare the incoming-message size check with the mplex specification's 1MB data-field limit. Confirm that message overhead does not trigger the restriction, and verify the resulting behavior with the repository's existing checks or test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100