Redundant isPeerId function
Open
Nobody has claimed this yet.
help wanted
kind/enhancement
P2
status/ready
- Dominant language
- JavaScript
- Stars
- 81
- Forks
- 42
- PR merge metrics
- No merged PRs in 30d
Description
After adding the class-is module with js-peer-id#84, the isPeerId function is redundant and can be removed js-peer-id/index.js#L291-L295.
Note: this was not removed with the addition of class-is since it is a breaking change and will need to change all its usages.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/index.js at the referenced isPeerId function around lines 291-295, then search the repository for all of its usages. Review how the class-is module from js-peer-id#84 replaces it and update the usages as needed. Done means the redundant function and its references have been removed without leaving callers behind.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100