Premarshal signed addresses records for self
Open
Nobody has claimed this yet.
kind/enhancement
- Dominant language
- Go
- Stars
- 6.9k
- Forks
- 1.3k
- Avg merge
- 13d 21h
- Merged PRs (30d)
- 1
Description
We don't need to marshal them every-time we send an `Identify` response to a peer.
Motivation: https://github.com/libp2p/go-libp2p/pull/747/files#r379700196
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the Identify response handles signed addresses records for self, using the linked motivation discussion for context. Confirm where repeated marshaling occurs and identify the relevant tests or response behavior to verify that the records are prepared once rather than marshaled for every peer response.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100