libp2p / libp2p/go-libp2p

Re-enable write coalescing in yamux and mplex

Open
#890 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Epic kind/enhancement
Dominant language
Go
Stars
6.9k
Forks
1.3k
Avg merge
13d 21h
Merged PRs (30d)
1

Description

Write coalescing was recently disabled in, https://github.com/libp2p/go-libp2p/pull/867, due to performance issues. We need to perform additional testing/profiling of write coalescing in yamux and mplex before reenabling them.

## Success Criteria
- [ ] Write coalescing in yamux is well tested and re-enabled, https://github.com/libp2p/go-yamux/issues/27
- [ ] Write coalescing in mplex is well tested and re-enabled, https://github.com/libp2p/go-mplex/issues/75

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull request 867 and the linked go-yamux issue 27 and go-mplex issue 75 to understand why write coalescing was disabled. Perform the additional testing and profiling requested for both transports; done means write coalescing is well tested and re-enabled in yamux and mplex.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.