libp2p / libp2p/go-libp2p

EvtLocalAddressesUpdated event is difficult to use correctly

Open
#863 5 comments 0 reactions 1 assignee View on GitHub

@aarshkshah1992 is already working on this.

Since Apr 2, 2020.

kind/enhancement
Dominant language
Go
Stars
6.9k
Forks
1.3k
Avg merge
13d 21h
Merged PRs (30d)
1

Description

For implementation convenience (I think?), `EvtLocalAddressesUpdated` doesn't _require_ that the announced addresses include diff information. Unfortunately, that means a robust application needs to implement address diffing logic even though go-libp2p always sets the `Diffs` field to true.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.