libp2p / libp2p/go-libp2p

[Kbucket] Better address management for candidate peers

Open
#808 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/enhancement
Dominant language
Go
Stars
6.9k
Forks
1.3k
Avg merge
13d 21h
Merged PRs (30d)
1

Description

Disassociating Routing Table membership from connectivity is done as part of https://github.com/libp2p/go-libp2p-kbucket/pull/50.

However, we might not have the address for a disconnected candidate when we want to dial it because it might have been evicted by the peer store as documented in the "Address managament" section of [this comment.](https://github.com/libp2p/go-libp2p-kad-dht/issues/283#issuecomment-583995529)

We need to fix this after https://github.com/libp2p/go-libp2p/issues/800 goes in and the Routing table _OR_ the DHT has a way to signal the peerstore to keep an address around till we need it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Address management discussion linked from the issue, then review libp2p/go-libp2p#800 and go-libp2p-kbucket#50 for the intended routing-table and peerstore relationship. Done means the routing table or DHT can ensure a disconnected candidate's address remains available until it must be dialed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.