libp2p / libp2p/go-libp2p

Reconsider filtering localhost addresses in identify

Open
#799 0 comments 0 reactions 1 assignee View on GitHub

@raulk is already working on this.

Since Feb 21, 2020.

kind/enhancement
Dominant language
Go
Stars
6.9k
Forks
1.3k
Avg merge
13d 21h
Merged PRs (30d)
1

Description

As of https://github.com/libp2p/go-libp2p/pull/770, we only send localhost addresses to local peers. This means these addresses _won't_ be advertised in the DHT. Usually, this is what you'd want and all local peers should be connected over MDNS anyways. However, @raulk wanted to take a bit of time to consider this.

This issue is here as a reminder to reconsider.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.