Identify sends multiple messages
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.9k
- Forks
- 1.3k
- Avg merge
- 13d 21h
- Merged PRs (30d)
- 1
Description
The identify spec says:
The protocol works by opening a stream to the remote peer you want to query, using /ipfs/id/1.0.0 as the protocol id string. The peer being identified responds by returning an Identify message and closes the stream.
go-libp2p's writeChunkedIdentifyMsg does not do this.
Instead it checks the size of the outgoing message, if it's bigger than legacyIDSize, it sends the message twice - once without the signed peer record and once with just that field in the protobuf.
This is not in the spec. Will go-libp2p be patched to be spec compliant or does the spec need updating?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in p2p/protocol/identify/id.go at writeChunkedIdentifyMsg and compare its message-sending behavior with the identify spec and the referenced js-libp2p pull request. Determine with maintainers whether go-libp2p or the specification should change; done means the agreed behavior is documented and covered by the relevant identify tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100