Fix flaky tests holepunch_test.go TestFailuresOnResponder/no_addrs_after_filtering
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.9k
- Forks
- 1.3k
- Avg merge
- 13d 21h
- Merged PRs (30d)
- 1
Description
This started failing after updating testify to v1.11 in #3439
The change in the above PR fixes the problem, but I'm not sure why the change works.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in holepunch_test.go at TestFailuresOnResponder/no_addrs_after_filtering and review the testify v1.11 update described in #3439. Reproduce the flaky failure and compare the change from that update; done means the test passes reliably and the reason for the fix is understood.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100