Select observed address manager provided address instead of NAT Manager addr
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.9k
- Forks
- 1.3k
- Avg merge
- 13d 21h
- Merged PRs (30d)
- 1
Description
Is this really what we should expect? Why doesn't the observed address take
precedence here?
_Originally posted by @MarcoPolo in https://github.com/libp2p/go-libp2p/pull/3075#discussion_r1968934713_
This makes sense. The observed addrs manager gets the result from multiple peers, and if that's what they're observing our address to be, it's more likely to be correct.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the observed address manager and NAT manager results are selected and compare the behavior described in this issue. Done means an observed address gathered from multiple peers takes precedence over the NAT Manager address, with tests covering the selection behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100