Renable pion logs for webrtc transport
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.9k
- Forks
- 1.3k
- Avg merge
- 13d 21h
- Merged PRs (30d)
- 1
Description
As the pion logs are too noisy, https://github.com/libp2p/go-libp2p/pull/2915 disables them.
We should reenable these logs after fixing the log level logs. In most cases these can simply be downgraded to debug, as these aren't error conditions.
For example this log line
```
2024-08-06T15:09:24.337-0700 ERROR webrtc-transport-pion v3@v3.2.50/sctptransport.go:184 Failed to accept data channel: failed to send ChannelOpen ACK: stream closed
```
happens whenever there the webrtc connection is closed and concurrently remote creates a datachannel. This is not an error condition for the connection.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #2915 and the Pion v3.2.50 sctptransport.go log site shown in the report. Identify messages that represent normal connection closure, adjust their levels, re-enable the transport logs, and verify that expected shutdown races no longer appear as errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100