libp2p / libp2p/go-libp2p

nat: use libp2p UserAgent for the UPnP comment string

Open
#2,307 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

effort/hours exp/beginner good first issue help wanted kind/enhancement P3
Dominant language
Go
Stars
6.9k
Forks
1.3k
Avg merge
13d 21h
Merged PRs (30d)
1

Description

This is probably a minor bug.
When creating a host, there is a libp2p.UserAgent() field
It should name the port forwarded upnp with this name, not the name of the library (libp2p)
![image](https://github.com/libp2p/go-libp2p/assets/5380115/1132da6c-6aac-49e2-bff5-76ff2ebb66de)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the NAT UPnP port-forwarding code and the host-creation path, then compare the current comment string with libp2p.UserAgent(). Done means the forwarded UPnP comment uses the host’s user agent rather than the library name. The issue names no file or test, so identify the relevant NAT/UPnP coverage before making the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.