libp2p / libp2p/go-libp2p

tcp / quic: rethink keep-alives

Open
#2,279 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

P3
Dominant language
Go
Stars
6.9k
Forks
1.3k
Avg merge
13d 21h
Merged PRs (30d)
1

Description

At the moment, we're enabling keep-alives on both the server and the client. In general, it should only be necessary for one of the nodes to send keep-alives. The server should be interested in getting rid of connections, unless the client is still interested in keeping the connection alive, which suggests that keep-alives should only be enabled on the client side.

Going one step further, once we're actually making use of 0-RTT in QUIC, it might make sense to let more QUIC connections run into the idle timeout, if we know that we can easily reestablish a 0-RTT connection to that server.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing where TCP and QUIC client/server keep-alives and idle timeouts are configured, then review how the proposed behavior relates to future QUIC 0-RTT use; done requires an agreed design and corresponding tests for connection lifetime behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.