libp2p / libp2p/go-libp2p

rcmgr: provide an easy API for getting the limits that are being enforced

Open
#2,166 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
6.9k
Forks
1.3k
Avg merge
13d 21h
Merged PRs (30d)
1

Description

## Situation/usecase
Kubo has commands to output for a user what the current resource manager/accountant limits are. According to @Jorropo, there isn't a clean/simple API for getting this back as a ConcreteLimitConfig. As a result, in Kubo, we are actually rebuilding at runtime the limit config we passed to go-libp2p (see discussion here: https://github.com/ipfs/kubo/pull/9680#discussion_r1122203182 ). It would be ideal to have ground truth from go-libp2p on what it is actually using vs. what Kubo thinks it's using.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the resource manager/accountant limit handling and the ConcreteLimitConfig reference in the issue. Compare the limits currently exposed by go-libp2p with the runtime configuration Kubo rebuilds, including the linked Kubo discussion. Done means a simple API returns the limits actually being enforced.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.