rcmgr: flaky TestResourceManagerServicePeerInbound
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.9k
- Forks
- 1.3k
- Avg merge
- 13d 21h
- Merged PRs (30d)
- 1
Description
https://github.com/libp2p/go-libp2p/actions/runs/4272132163/jobs/7437069130
```
=== RUN TestResourceManagerServicePeerInbound
rcmgr_test.go:248: stream reset
rcmgr_test.go:248: stream reset
rcmgr_test.go:258:
Error Trace: /home/runner/work/go-libp2p/go-libp2p/p2p/test/resource-manager/echo_test.go:56
/home/runner/work/go-libp2p/go-libp2p/p2p/test/resource-manager/rcmgr_test.go:258
Error: Not equal:
expected: itest.EchoStatus{StreamsIn:7, EchosIn:6, EchosOut:6, IOErrors:0, ResourceServiceErrors:1, ResourceReservationErrors:0}
actual : itest.EchoStatus{StreamsIn:7, EchosIn:5, EchosOut:5, IOErrors:0, ResourceServiceErrors:2, ResourceReservationErrors:0}
Diff:
--- Expected
+++ Actual
@@ -2,6 +2,6 @@
StreamsIn: (int) 7,
- EchosIn: (int) 6,
- EchosOut: (int) 6,
+ EchosIn: (int) 5,
+ EchosOut: (int) 5,
IOErrors: (int) 0,
- ResourceServiceErrors: (int) 1,
+ ResourceServiceErrors: (int) 2,
ResourceReservationErrors: (int) 0
Test: TestResourceManagerServicePeerInbound
--- FAIL: TestResourceManagerServicePeerInbound (0.33s)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running TestResourceManagerServicePeerInbound and inspect the failure around lines 248 and 258 of p2p/test/resource-manager/rcmgr_test.go. Read p2p/test/resource-manager/echo_test.go around line 56 to understand the reported status values. Done means the flaky test has a reliable outcome matching the intended echo and resource-service counts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100