libp2p / libp2p/go-libp2p

Outdated comment for confidence variable in autonat

Open
#1,890 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

P3
Dominant language
Go
Stars
6.9k
Forks
1.3k
Avg merge
13d 21h
Merged PRs (30d)
1

Description

#### Location

autonat.go file
lines 37 - 42

```
// Reflects the confidence on of the NATStatus being private, as a single
// dialback may fail for reasons unrelated to NAT.
// If it is <3, then multiple autoNAT peers may be contacted for dialback
// If only a single autoNAT peer is known, then the confidence increases
// for each failure until it reaches 3.
confidence int
```

#### Description

It seems that initially the confidence variable was used for private status, now it seems to measure the confident in the current status, but the comments haven't been updated.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with autonat.go lines 37–42 and inspect the current uses of the confidence variable to confirm what status it represents. Update the comment so it accurately describes that behavior, then verify the comment matches the implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.