libp2p / libp2p/go-libp2p

early muxer selection: fail early

Open
#1,889 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

effort/days exp/intermediate help wanted kind/enhancement P3
Dominant language
Go
Stars
6.9k
Forks
1.3k
Avg merge
13d 21h
Merged PRs (30d)
1

Description

When early muxer selection fails even though both sides sent a list of muxers, we should fail immediately, instead of falling back to multistream negotiation. We need to take extra care that we don't fail for peers that don't support early muxer negotiation, we still need the multistream negotiation in that case.

This is an optimization that will save one round trip when there's no supported muxer.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing early muxer selection and its fallback into multistream negotiation. Reproduce the case where both peers send muxer lists but share none, then verify that it fails without the extra round trip while peers lacking early muxer support still reach multistream negotiation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems, networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.