connmgr: refactor to remove segment locks and bucketsMu
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.9k
- Forks
- 1.3k
- Avg merge
- 13d 21h
- Merged PRs (30d)
- 1
Description
It looks OK for an urgent fix. Let's come back and revisit this to see if there are other better solutions. Adding to the locks is getting the situation more complicated.
_Originally posted by @julian88110 in https://github.com/libp2p/go-libp2p/pull/1860#pullrequestreview-1173007748_
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the connmgr implementation and the discussion in pull request 1860, focusing on the segment locks and bucketsMu named in this issue. The issue provides no files, tests, or settled replacement design, so completion would require agreeing on a simpler locking approach and confirming the urgent fix's behavior remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 15/100