reuseport: avoid calling reuseDial when we don't actually want to reuse the port
Open
Nobody has claimed this yet.
status/deferred
- Dominant language
- Go
- Stars
- 6.9k
- Forks
- 1.3k
- Avg merge
- 13d 21h
- Merged PRs (30d)
- 1
Description
That way, we can get rid of some of the fallback logic. See the TODO here: https://github.com/libp2p/go-reuseport-transport/pull/6#discussion-diff-245203302R42
Alternatively, we can remove the TODO.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the reuseport code around reuseDial and the TODO referenced in pull request #6, especially the discussion at the linked diff. Determine whether reuseDial is called when port reuse is not wanted; done means either removing that unnecessary call and fallback logic or explicitly removing the TODO after confirming no change is needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100