quic: improve simultaneous connect logic
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.9k
- Forks
- 1.3k
- Avg merge
- 13d 21h
- Merged PRs (30d)
- 1
Description
We can fail the handshake earlier by hooking into the GetConfigForClient callback of the tls.Config.
This would require us to not save the peer ID in the holePunching map, and just use the remote address obtained from the net.Conn of the tls.ClientHelloInfo. This would bring QUIC more in line with what we're doing for hole punching in TCP: there we're happy to accept a hole-punch connection with any incoming connection coming from the expected remote address.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the QUIC handshake and the tls.Config GetConfigForClient callback, then compare the existing holePunching map logic with TCP hole punching. Done means the peer ID is no longer saved in holePunching, the remote address comes from net.Conn in tls.ClientHelloInfo, and the handshake can fail earlier for an unexpected address.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100