libp2p / libp2p/go-libp2p

tcp: flaky TestTcpTransport/github.com/libp2p/go-libp2p-testing/suites/transport.SubtestStreamReset

Open
#1,423 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/bug
Dominant language
Go
Stars
6.9k
Forks
1.3k
Avg merge
13d 21h
Merged PRs (30d)
1

Description

```
2022-04-22T14:50:24.4826289Z === RUN TestTcpTransport/github.com/libp2p/go-libp2p-testing/suites/transport.SubtestStreamReset
2022-04-22T14:50:24.4826888Z panic: Fail in goroutine after TestTcpTransport/github.com/libp2p/go-libp2p-testing/suites/transport.SubtestStreamOpenStress has completed
2022-04-22T14:50:24.4826907Z
2022-04-22T14:50:24.4827036Z goroutine 52338 [running]:
2022-04-22T14:50:24.4827179Z testing.(*common).Fail(0xc00753ed00)
2022-04-22T14:50:24.4827465Z C:/hostedtoolcache/windows/go/1.17.8/x64/src/testing/testing.go:710 +0xe5
2022-04-22T14:50:24.4827678Z testing.(*common).Error(0x26b4d3f8c20, {0xc0092b1f78, 0xc00925c1a0, 0x0})
2022-04-22T14:50:24.4827923Z C:/hostedtoolcache/windows/go/1.17.8/x64/src/testing/testing.go:812 +0x4f
2022-04-22T14:50:24.4828355Z github.com/libp2p/go-libp2p-testing/suites/transport.fullClose(0xc00753ed00, {0x1029570, 0xc00925c1a0})
2022-04-22T14:50:24.4828933Z C:/Users/runneradmin/go/pkg/mod/github.com/libp2p/go-libp2p-testing@v0.9.2/suites/transport/stream_suite.go:64 +0xd3
2022-04-22T14:50:24.4829660Z github.com/libp2p/go-libp2p-testing/suites/transport.SubtestStreamOpenStress.func3.1.1()
2022-04-22T14:50:24.4830550Z C:/Users/runneradmin/go/pkg/mod/github.com/libp2p/go-libp2p-testing@v0.9.2/suites/transport/stream_suite.go:339 +0x65
2022-04-22T14:50:24.4831009Z created by github.com/libp2p/go-libp2p-testing/suites/transport.SubtestStreamOpenStress.func3.1
2022-04-22T14:50:24.4831513Z C:/Users/runneradmin/go/pkg/mod/github.com/libp2p/go-libp2p-testing@v0.9.2/suites/transport/stream_suite.go:337 +0x95
2022-04-22T14:50:24.4834196Z FAIL github.com/libp2p/go-libp2p/p2p/transport/tcp 61.726s
2022-04-22T14:50:24.4837494Z FAIL

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing TestTcpTransport and its transport.SubtestStreamReset failure, then inspect the reported stream_suite.go locations for fullClose and SubtestStreamOpenStress. Trace the goroutine cleanup around the reported panic and verify the transport suite completes without failures after repeated runs.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.