mDNS's new implementation doesn't perform as well
@schomatis is already working on this.
Since Jun 13, 2022.
- Dominant language
- Go
- Stars
- 6.9k
- Forks
- 1.3k
- Avg merge
- 13d 21h
- Merged PRs (30d)
- 1
Description
Sorry, no hard number to provide other than "upgrading to the new implementation makes my test fails all over the place, randomly.
I have a series of go test for my project that simulate locally the interactions of a series of services. Those test rely on mDNS for local discovery.
Until now I had a simple `time.Sleep()` to give this discovery some time to connect, everything was fine. While updating to a more recent go-libp2p, I changed my code to use the new mDNS implementation, resulting in broken tests. I changed my `time.Sleep()` by something smarter that wait until the discovery worked, up to a minute, but that doesn't seems to be enough.
It seems to me that often the discovery is slower, and sometimes never succeed in a 1 minute period.
Is that something to expect? Is this a bug?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.