libp2p / libp2p/go-libp2p-pubsub

Improve handling of connection errors and dead peers

Open
#433 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
364
Forks
221
PR merge metrics
No merged PRs in 30d

Description

Starting with #430 we now short-circuit attempts to reconnect to peers when we fail to open a stream.
We still try to do this for dead peers that are still perceive as connected but this logically short-circuits when the stream establishment attempt fails.

This is an improvement over what we previously had, where we could get into "respawning writer" loops.
But it does have a drawback: it is possible to have multiple connections to a peer and pick the wrong connection to open a stream, leading to an otherwise healthy peer being ignored.

We need to introduce a principled mechanism for handling reconnect attempts; quite likely a backoff and possibly a blacklist will be enough.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #430 and tracing the reconnect attempts, stream-opening, and stream-establishment paths described here. Define how reconnect attempts should behave for dead peers and multiple connections, then verify that the chosen mechanism prevents respawning-writer loops without ignoring healthy peers.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems, networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.