libp2p / libp2p/go-libp2p-daemon

Listen flag is confusing

Open
#249 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
95
Forks
41
PR merge metrics
No merged PRs in 30d

Description

We use the `listen` flag to control socket. There's also a `noListenAddrs` which specifies "don't listen on any libp2p transports". There's also an option `hostAddrs` which specifies which libp2p transports/addresses we should listen on.

We should change this to:

* `-control`, or `-controlSocket`, etc. for the control address.
* `listenAddrs` and `noListenAddrs` for libp2p listen addresses.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the CLI definitions and usages of `listen`, `noListenAddrs`, and `hostAddrs`, along with the control socket option. Trace how these flags select the control address versus libp2p listen addresses. Done means the names clearly distinguish those purposes and all related help text and consumers use the new names.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, networking
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.