libp2p / libp2p/go-libp2p-daemon

Windows failure due to prometheus/client_golang

Open
#143 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
95
Forks
41
PR merge metrics
No merged PRs in 30d

Description

Failure during `go get ./...` in HEAD, on AppVeyor - https://ci.appveyor.com/project/nimbus/nim-libp2p/builds/27746839/job/dnpugbq12b2t298q#L579 :

```text
# github.com/prometheus/client_golang/prometheus
..\goblin\pkg\mod\github.com\prometheus\client_golang@v1.1.0\prometheus\process_collector_windows.go:78:9: assignment mismatch: 2 variables but "golang.org/x/sys/windows".GetCurrentProcess returns 1 values
```

Upstream issue: https://github.com/prometheus/client_golang/issues/642

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the AppVeyor failure from `go get ./...` and the linked prometheus/client_golang issue. Reproduce the Windows build if possible and identify the dependency compatibility change needed; done means the dependency step passes on AppVeyor without the `GetCurrentProcess` assignment error.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, prometheus
Domain
ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.