libp2p / libp2p/cpp-libp2p

yamux stream destructor

Open
#240 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
492
Forks
130
No merged PRs in 30d

Description

Description
  • YamuxedConnection must hold weak_ptr<YamuxStream>
  • ~YamuxStream must cleanup resources immediately
  • remove YamuxedConnection cleanup timer
  • fix yamux pending streams broken by this change
Motivation

close streams earlier to avoid CONNECTION_TOO_MANY_STREAMS

Current Implementation

streams are not closed until timer

Are you planning to do it yourself in a pull request ?

Maybe

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the YamuxedConnection and YamuxStream implementations, then trace the cleanup timer and pending-stream handling. Done means connection stream references are weak, YamuxStream destruction cleans resources immediately, the timer is removed, and pending streams still work without causing CONNECTION_TOO_MANY_STREAMS.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.