libp2p / libp2p/cpp-libp2p

Refactor unsafe code

Open
#226 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted
Dominant language
C++
Stars
492
Forks
130
No merged PRs in 30d

Description

  • read/write lambda captures Bytes - use sptr<Bytes> or SharedFn
    • src/protocol/gossip/impl/stream.cpp Stream::beginWrite

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/protocol/gossip/impl/stream.cpp at Stream::beginWrite and inspect how the read/write lambdas capture Bytes. Replace that capture with sptr or SharedFn as appropriate, then verify the change with the repository's available build or test checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.