libp2p / libp2p/cpp-libp2p

Yamux newStream does not work

Open
#168 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted
Dominant language
C++
Stars
492
Forks
130
PR merge metrics
No merged PRs in 30d

Description

There are two versions for new stream creation in cpp-libp2p yamux - sync and async. Async version is not working - we always will have an error "closed by remote peer" when we use it. The actual problem is that the stream is created in both cases, but in the case of the async version, it never returned to the user's callback. The second problem is that the stream creation in both cases is done via the same method under the hood, but in the case of the async approach, we have additional messages on the line, which look unnecessary to be sent over. Thus, the flow seems broken in the case of the async approach of streams creation which is generally preferred.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the synchronous and asynchronous yamux newStream implementations and the user's callback path. Compare the messages sent by both approaches and verify that the async callback receives the created stream without the unnecessary messages that lead to the remote-peer closure.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.