libigl / libigl/libigl

Use C++11 random rather than C-style rand

Open
#1,613 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
C++
Stars
5.1k
Forks
1.2k
Avg merge
7h 33m
Merged PRs (30d)
8

Description

Creating this pull request on behalf of @jdumas who brings up this issue here https://github.com/libigl/libigl/pull/1597 .

There are many functions that use Eigen::Random or rand or shuffle that apparently should use C++11 style random number generators. We should do this as one pass and provide a standard to put in the style guidelines that new functions can follow.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked pull request 1597 and locating all uses of Eigen::Random, rand, and shuffle across the library. Determine the project-wide C++11 random-number standard and identify the affected functions and style-guideline changes; done means the one-pass migration and documented standard are complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.