hunk.final_committer.name not work if email is empty
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 408
- Avg merge
- 2d 57m
- Merged PRs (30d)
- 7
Description
Hi, I found this error:
if email is missing, it gives error "Signarure cannot have an empty name or email"
in libgit2 Slack channel we discuss it and end up that in wrap_signature pygit2 creates new signature where email cannot be empty. It maybe should use git_signature_dup instead?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating wrap_signature and tracing how hunk.final_committer.name handles a missing email. Compare the current signature creation with the reported git_signature_dup possibility, then add or run a regression test covering an empty email and verify that the signature is accepted without the reported error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, python
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100