libgit2 / libgit2/pygit2

test_binary_diff() fails

Open
#1,303 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.7k
Forks
408
Avg merge
2d 57m
Merged PRs (30d)
7

Description

I am running tests at my machine and test_binary_diff() fails with following error:

repo = pygit2.Repository('/tmp/pytest/test_binary_diff0/binaryfilerepo/.git/')

    def test_binary_diff(repo):
        diff = repo.diff('HEAD', 'HEAD^')
        assert PATCH_BINARY == diff.patch
        diff = repo.diff('HEAD', 'HEAD^', flags=DiffOption.SHOW_BINARY)
>       assert PATCH_BINARY_SHOW == diff.patch
E       AssertionError: assert 'diff --git a...vrst3ey5{\n\n' == 'diff --git a...vrst3ey5{\n\n'
E         Skipping 154 identical leading characters in diff, use -v to show
E           teral 8
E         - PcwS>j%FIhFs^kIy3n&7R
E         ?   ^^^^
E         + Pc${NM%FIhFs^kIy3n&7R
E         ?   ^^^^
E           ...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running test_binary_diff() and compare the generated SHOW_BINARY diff with PATCH_BINARY_SHOW, focusing on the differing binary content shown in the assertion. Trace the repository diff call and its binary-output behavior; the work is done when the test produces the expected stable patch output.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, python
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.