libgit2 / libgit2/libgit2sharp
Ensure any passed in string doesn't contains the `\0` character
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.5k
- Forks
- 925
- PR merge metrics
- No merged PRs in 30d
Description
Following discussion with @ethomson in https://github.com/libgit2/libgit2sharp/pull/530#issuecomment-26069471 , some methods are now protected against the evil zero character (cf . https://github.com/libgit2/libgit2sharp/commit/28d1820f0d45f5d75e5a9f08e009898430b21561, for instance).
It would make sense to also protect every remaining string in the API that is eventually passed to libgit2.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the protections discussed in pull request #530 and commit 28d1820f0d45f5d75e5a9f08e009898430b21561, then audit the remaining API strings passed to libgit2. Done means every applicable passed-in string is protected against the \0 character.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, git
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100