libgit2 / libgit2/libgit2sharp
Protect repository instances from domain wide GlobalSettings changes
Open
Nobody has claimed this yet.
Up for grabs
- Dominant language
- C#
- Stars
- 3.5k
- Forks
- 925
- PR merge metrics
- No merged PRs in 30d
Description
As seen in https://github.com/libgit2/libgit2sharp/issues/1119
- Paybe should we also improve the documentation of this type. Indeed, this type holds registrations that exceeds the lifespan of a
Repository.I feel that pretty strange side-effects may happen would we blindly deregister while some repos are still alive and leveraging those. - Perhaps some kind of locking of global values while any Repository objects are not yet disposed could provide some value?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue 1119 and tracing the GlobalSettings and Repository types, especially how registrations outlive Repository instances. Define what protection or locking should guarantee while repositories remain alive, and whether the documentation should describe these lifecycle constraints; done means the intended behavior and scope are agreed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100