`git_diff_file_cb` progress always 0
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 10.6k
- Forks
- 2.7k
- PR merge metrics
- No merged PRs in 30d
Description
since file_cb define in this way
https://github.com/libgit2/libgit2/blob/fb439c975a2de33f5b0c317f3fdea49dc94b27dc/include/git2/diff.h#L458-L470
may I know any reason why the git_diff_file_cb progress always 0 here?
https://github.com/libgit2/libgit2/blob/fb439c975a2de33f5b0c317f3fdea49dc94b27dc/src/patch.c#L25
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the callback definition in include/git2/diff.h at lines 458-470, then trace the progress value at src/patch.c line 25. Reproduce the callback behavior with a diff and determine whether the documented progress contract is being met; done means the behavior has a clear explanation and an appropriate regression check or documented resolution.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, git
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100