libgdx / libgdx/packr

JNI Version 9 and 10

Open
#209 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
2.6k
Forks
174
PR merge metrics
No merged PRs in 30d

Description

It appears that packr currently supports only JNI Version 6 and 8

https://github.com/libgdx/packr/blob/9c9bb9d050524eec58acddfca85e606fbab31637/PackrLauncher/src/main/cpp/packr.cpp#L582-L590

https://github.com/libgdx/packr/blob/9c9bb9d050524eec58acddfca85e606fbab31637/PackrLauncher/src/main/headers/packr.h#L23-L25

But there are now two newer versions (link). JNI_VERSION_10 is used for Java 10 through to at least 17.

#define JNI_VERSION_9   0x00090000
#define JNI_VERSION_10  0x000a0000

I haven't encountered any problems with this so far, but I know that I did need to set "jniVersion": 8 in my config.json. For people upgrading to newer JVMs, if you are encountering issues with JNI, you might want to investigate here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in PackrLauncher/src/main/cpp/packr.cpp around lines 582-590 and PackrLauncher/src/main/headers/packr.h around lines 23-25, then compare the current JNI version handling with the linked JNI specification. Done means newer JVMs using JNI_VERSION_9 or JNI_VERSION_10 are supported without requiring users to set jniVersion to 8.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, java
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.