bufferevent_priority_set doesn't work so well
Open
Nobody has claimed this yet.
libevent-2.1
prio:wishlist
type:enhancement
- Dominant language
- C
- Stars
- 12k
- Forks
- 3.5k
- Avg merge
- 12h 55m
- Merged PRs (30d)
- 6
Description
If bufferevent_priority_set() is to work, it needs to change the priority assigned to every future event and callback. But events and callbacks can be initialized after bufferevent_priority_set() is called -- for example, in be_socket_setfd.
Further, it should really affect the priority of events used to implement rate-limiting.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading bufferevent_priority_set() and the be_socket_setfd path. Trace which events and callbacks are created before and after priority changes, including the events used for rate-limiting. Done means a priority change consistently applies to future events, callbacks, and rate-limiting events.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100