liberusoftware / liberusoftware/documentation

MODULES.md section 24's --min=100 is unreachable for code extracted from an untested host

Open
#22 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
4
Forks
0
PR merge metrics
No merged PRs in 30d

Description

architecture/MODULES.md §24 sets coverage at --min=100. That is reachable for a greenfield module and unreachable for code extracted out of an untested host — not as a matter of effort, but as a matter of sequencing: the extraction and the test-writing cannot land in the same commit, so the gate blocks the move that makes the code testable in isolation.

What the fleet actually meets

Almost none of it. Of the 40 installed packages in boilerplate-laravel, only settings has tests — 5 files. identity-core, organizations-teams and webhooks have zero. Coverage across the fleet spans 7–100%.

So §24's floor is currently enforced nowhere, which means the practical effect of holding a new product to it is to stop extraction rather than to improve coverage.

What was decided downstream

Floor
Greenfield module 100%--min=100, per §24
Module extracted from the host 80%, ratcheting upward, never downward

Recorded as ADR 0001.

Ask

Either add an extraction case to §24 with a stated floor and a ratchet requirement, or confirm that 100% is intended to apply to extractions too — in which case the fleet's own packages are the first thing that needs fixing, not a downstream product's ADR.

Found while auditing ecommerce-laravel against the standards.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with architecture/MODULES.md §24 and compare its 100% floor with docs/adr/0001-coverage-floor-for-extracted-modules.md. Review the cited package coverage figures and determine which extraction policy the standard should state. Done means the section and ADR are consistent and the extraction rule or confirmation is explicit.

Written by the indexing model from the issue text.

Assessment

Tech stack
laravel
Domain
documentation, testing
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.