liberusoftware / liberusoftware/.github

Add a fourth reusable workflow for themes' visual.yml (THEMES.md section 18.1)

Open
#9 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

standards/THEMES.md §18.1 requires a theme repository to ship four workflows — install.yml, tests.yml, compatibility.yml and visual.yml — against a module's three.

There is no reusable package-visual.yml in this repository, and no theme in the fleet has a visual.yml at all.

Ask

A fourth reusable workflow covering what §18.1 asks of it: visual regression and accessibility checks. Pseudo-localization and RTL direction checks belong here too — TRANSLATIONS.md and THEMES.md §18.1 both require them, and they are theme-shaped rather than module-shaped, so splitting them from the module test workflow keeps each check in the repository that can fail it.

Context

ecommerce-laravel creates a theme-ecommerce in the first wave of its migration, and per-merchant child themes after that. Each will need this workflow, and the standard already names it, so the alternative is every theme author writing their own.

Worth noting the downstream decision this interacts with: ecommerce-laravel is shipping en only, which leaves the RTL requirement in both standards deliberately unexercised. A working visual.yml is what would make exercising it cheap later.

Found while planning theme packaging for ecommerce-laravel.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading standards/THEMES.md §18.1 and the relevant requirements in TRANSLATIONS.md, then inspect the existing reusable workflows to understand their structure. Add the missing package-visual.yml workflow with visual regression, accessibility, pseudo-localization, and RTL checks. Done means theme repositories can reuse it to cover every check named by the standards.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, yaml
Domain
accessibility, ci-cd, internationalization, localization, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.