liberusoftware / liberusoftware/.github

package-tests.yml should invoke Composer scripts, and upload coverage to Codecov

Open
#6 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

MODULES.md §4 r20 says test bootstrap is shared once while each repository owns its own Composer aliases and CI workflows. The only reading under which the alias clause means anything is that the reusable workflow invokes a package's Composer scripts rather than binaries directly — otherwise the aliases exist and nothing ever calls them.

package-tests.yml currently runs binaries.

Ask

  1. Invoke Composer scripts. composer test, composer analyse, composer lint — whatever the package declares — so a package that needs different flags expresses that in its own composer.json rather than needing a workflow change.
  2. Upload coverage to Codecov. Coverage is generated and then discarded; REPOSITORIES.md §6.3 builds badge URLs that have nothing behind them.

Context

ecommerce-laravel is planning ~100 module repositories, each shipping the three workflows MODULES.md §24.1 fixes them at, all as 12–22 line thin callers into this repository. Every one of them inherits whatever this workflow does, which is why it is worth getting right before the fan-out rather than after.

Found while planning module CI for ecommerce-laravel.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading package-tests.yml and the workflow conventions described in MODULES.md §4 and §24.1. Check how each package declares its Composer scripts in composer.json, then update the workflow so those scripts are invoked and the generated coverage is uploaded to Codecov; done means package-specific aliases control testing, analysis, and linting while coverage reaches Codecov.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, php, yaml
Domain
ci-cd, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.