libcord-tech / libcord-tech/gauntlet

Toggling site template from form submission URL performs action again

Open
#28 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
2
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Toggling the template-overall=none from a form submission URL (that is, a URL with application/x-www-form-urlencoded data as query parameters) will trigger that action again. For instance, the move keybind navigates to a URL with parameters such as region_name and move_region, and toggling the site template after moving will attempt to move again, redirecting to page=change_region instead of simply toggling the site template as expected.

I'm not sure if we really have a way of purely toggling the site template in situations like these short of injecting the NationStates sidebar, CSS stylesheet, etc. ourselves which feels like more effort than it's really worth. But I do think we'd be better off not triggering actions again when users have already performed them and intuitively would expect a toggle to simply change the site appearance rather than performing actions again.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the site-template toggle and the handling of form-submission URLs, then reproduce the move keybind case with region_name and move_region parameters. Done means toggling the template changes only the site appearance and does not repeat the prior action or redirect to page=change_region.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.