utf-8 safety
Open
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 491
- Forks
- 81
- PR merge metrics
- No merged PRs in 30d
Description
so turns out that passing invalid utf-8 to glib is unsafe: https://gitlab.gnome.org/GNOME/gtksourceview/-/issues/402
but it seems that lgi_marshal_2c doesn't do that: https://sources.debian.org/src/lua-lgi/0.9.2-4/lgi/marshal.c/?hl=956#L956
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lgi/marshal.c around lgi_marshal_2c, at the linked line near 956, and compare its invalid-UTF-8 handling with the referenced GTKSourceView/GLib issue. Determine whether the path can pass unsafe data to GLib; done means the unsafe behavior is addressed and the result is verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, lua
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100