lfglabs-dev / lfglabs-dev/starknet.quest

Redesign the stats detail quest page - Modify the "Unique Users" card. #1082

Open
#1,083 10 comments 0 reactions 1 assignee View on GitHub

@code-stan is already working on this.

Since Apr 24, 2025.

Good first issue onlydust-wave open for contribution
Dominant language
TypeScript
Stars
39
Forks
180
PR merge metrics
No merged PRs in 30d

Description

Description 📹

Current :
Image

New design :
Image

Figma File :
https://www.figma.com/design/fh0OAvj4AS08kHoSxu3DkE/%F0%9F%9A%80-Starknet-Quest?node-id=6870-5648&t=ZvvWJW4vZ48J0Mi6-1

Modify the "Users Who Finished the Quest" card and add icon to the right

The purpose of this issue is to modify the “Users Who Finished the Quest” card and add an icon to the right on the Starknet Quest platform.
Issue Details
• Current State: The “Users Who Finished the Quest” card does not have an icon on the right and does not match the new design.
• Proposed State: Update the “Users Who Finished the Quest” card to align with the updated Figma design and add an icon to the right.
• Design: The updated design is available on Figma (link provided in the issue description).
Actions to Take
• Fork and Branch Creation:
• Fork the repository and create a new branch using the issue number.
• Implementation of Changes:
• Modify the “Users Who Finished the Quest” card based on the Figma design.
• Add an icon to the right of the card as specified.
• Testing and Validation:
• Verify that the modified card matches the Figma specifications.
• Test locally to ensure no visual or functional regressions occur.
• Commit and Submission:
• Make a commit with a clear message describing the updates made to the “Users Who Finished the Quest” card.
• Submit a pull request closing the issue.

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
    
  2. Implement Changes:
    [Insert Code snippet if needed with a mardown todo list]

  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: [Short description of the fix]"
    

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.