lexrus / lexrus/LTMorphingLabel

Morphing animation messes up San Francisco Display font

Open
#61 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
Swift
Stars
8.1k
Forks
776
PR merge metrics
No merged PRs in 30d

Description

I really like how the colon character (:) is a little bit raised up and not touching the baseline in the San Francisco Display font introduced in WWDC 2015. Here is how it is supposed to look like:

screen shot 2016-07-25 at 3 22 54 pm

However, once I changed the text of the label to something else with the .Fall animation, the colon dropped onto the baseline:

screen shot 2016-07-25 at 3 23 22 pm

I believe that this is caused by the way you draw the text using Core Text. Can you fix it?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the colon positioning change when a UILabel's text is updated with the .Fall animation, then inspect the Core Text drawing path mentioned in the report. Compare the rendered colon before and after the animation; done means the San Francisco Display colon remains raised above the baseline in both states.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.