letsencrypt / letsencrypt/pebble

pebble/test/chisel2.py will fail when the TOS url changes

Open
#393 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
787
Forks
176
PR merge metrics
No merged PRs in 30d

Description

I believe we consider this improper behaviour:
https://github.com/letsencrypt/pebble/blob/main/test/chisel2.py#L67-L71

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading test/chisel2.py at lines 67-71 and inspect how the test depends on the TOS URL. Confirm the failure mode when that URL changes, then update the test behavior so a TOS URL change does not cause this improper failure. Done means the relevant test remains valid when the TOS URL changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.