letsencrypt / letsencrypt/boulder

admin: consider a new "unblock key" subcommand

Open
#9,001 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5.8k
Forks
649
Avg merge
3d 23h
Merged PRs (30d)
24

Description

If a key gets erroneously blocked, removing it from the blockedKeys table requires manual database surgery, which should always be avoided. To prevent the need for database surgery, we could consider adding an "unblock key" subcommand to the admin tool.

However, unblocking keys is itself a very dangerous operation. Any attempt to make this easier must be accompanied by lots of checks and safeguards. We should consider addressing https://github.com/letsencrypt/boulder/issues/9000 instead.

See https://bugzilla.mozilla.org/show_bug.cgi?id=2060359 for context.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue 9000 and the linked Bugzilla report 2060359; this issue names no files, tests, or entry points. Define whether a safeguarded admin subcommand is appropriate and what checks are required before considering the work done.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.